Browser prefix is operator #458
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update lesshint to work with shellscape/postcss-values-parser#45, which will return a number for +5 instead of an operator and a number. So, check both operators and numbers, ignore any numbers that don’t start with an operator (+-*/), allow the node to be the last node (no nextElement), and use a whitespace regex to check the none spacing instead of the exact value.
jwilsson
approved these changes
Feb 19, 2018
There was a problem hiding this comment.
LGTM, pending a solution in shellscape/postcss-values-parser#45.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue, if any, does this resolve?
#433
Is there anything in this PR that needs extra explaining or should something specific be focused on?
This is intended to work with shellscape/postcss-values-parser#45, so I’d expect any CI to fail on this PR, it is intended as more of an explanation of my shellscape/postcss-values-parser#38 (comment) rather than being ready to be merged.
If we decide this is the route to go down, I can update this PR after the fix for postcss-values-parser is published and update to the new version.