Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): test matrix include go1.12 up to go1.18 #30

Merged
merged 3 commits into from Apr 20, 2022

Conversation

mroth
Copy link
Contributor

@mroth mroth commented Apr 20, 2022

This tests back from the version specified in go.mod to current stable.

This should enable detection of any breaking version changes as part of the dependencies update PR.

subtask forked from #28.

This tests back from the version specified in go.mod to current stable.
This should enable detection of any breaking version changes as part of
the dependencies update PR.

subtask forked from lestrrat-go#28.
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #30 (f253a4f) into master (e9f389d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   79.47%   79.47%           
=======================================
  Files           5        5           
  Lines         268      268           
=======================================
  Hits          213      213           
  Misses         38       38           
  Partials       17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9f389d...f253a4f. Read the comment docs.

@mroth
Copy link
Contributor Author

mroth commented Apr 20, 2022

There appears to be a tooling issue with the version of golangci-lint here working with go1.18. As a first attempt before spelunking all of the golangci-lint changelogs, I'm going to just update the version of golangci-lint to latest stable and see if that fixes things without causing any issues (it appears from the config file not many linters are being run).

@mroth mroth marked this pull request as ready for review April 20, 2022 00:10
@lestrrat
Copy link
Collaborator

Thanks, as for golangci-lint, I'm going to refactor it out to its own job after merging this.

@lestrrat lestrrat merged commit 6ec72ea into lestrrat-go:master Apr 20, 2022
@mroth mroth deleted the updateci branch April 20, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants