Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render expired on Authorizations when they are expired #315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jvanasco
Copy link
Contributor

This is a partial fix to #303

I am not sure if this is the correct place or way (does it persist?) to implement this. I would not be offended (and actually happy) if a maintainer were to better implement this PR.

This simply effects the correct state transition for the Authorization object (see https://tools.ietf.org/html/rfc8555#section-7.1.6) where the state is rendered to clients as expired after the expiry time.

@jvanasco jvanasco changed the title authorization update Render expired on Authorizations when they are expired Jun 12, 2020
@jsha
Copy link
Contributor

jsha commented Jun 22, 2020

Thanks for filing @jvanasco! Things have been a bit busy here but this is on our radar to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants