Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use esm package with mocha #3

Closed
wants to merge 1 commit into from
Closed

Use esm package with mocha #3

wants to merge 1 commit into from

Conversation

PhilippRaab
Copy link
Contributor

No description provided.

@satchmorun
Copy link
Collaborator

Now that the other 2 PRs are merged, do you mind squashing this down? Seems that this PR can now just be the one commit "Use esm package with mocha".

@marijnh
Copy link
Contributor

marijnh commented Sep 23, 2020

What does this fix? With recent Mocha versions ES module tests run fine without loading esm

@PhilippRaab
Copy link
Contributor Author

I get following error when not using esm:

image

@marijnh
Copy link
Contributor

marijnh commented Sep 23, 2020

With Mocha 8? Which node version are you running?

@PhilippRaab
Copy link
Contributor Author

It's working now. I had to update node to version > 12.11 (see: mochajs/mocha#4038).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PhilippRaab @satchmorun @marijnh @dtPhilippRaab