Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update nestjs dependencies #517

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mahsumurebe
Copy link

@mahsumurebe mahsumurebe commented Jun 16, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #516

What is the new behavior?

Does this PR introduce a breaking change?

    • Yes
    • No

Other information

@pneme
Copy link

pneme commented Jun 20, 2023

Any estimate for merging this? My team is excited for SWC support in v10 Nest.js for which this bump is needed 🙏

Copy link
Author

@mahsumurebe mahsumurebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any news ?

@v-petukhov
Copy link

Hey @liaoliaots ! Any updates?

@andresemartinez
Copy link

@mahsumurebe, I think this PR should also update the requiremenets in the readme for Nest and Node

@satanshiro
Copy link

any news? it has been some time since last commit is this maintained? @liaoliaots

@mahsumurebe
Copy link
Author

mahsumurebe commented Jul 3, 2023

Hi @liaoliaots

Necessary improvements have been made. Can you check the pull request?

@heiba
Copy link

heiba commented Jul 6, 2023

@liaoliaots Would much appreciate your support on this. We're kind of blocked on upgrading to Nest.js v10 because of the nestjs-redis not supporting it. Anything I can do from my side, I will be glad to support. I thank you for your efforts on this project.

@jorcelinojunior
Copy link

Hi @liaoliaots

Can you check the pull request?

@satanshiro
Copy link

it's been close to 2 months now, is it time to create a fork instead?

@v-petukhov
Copy link

it's been close to 2 months now, is it time to create a fork instead?

It's already created by @Songkeys

#516 (comment)

@dougal83
Copy link

It is possible to override dependencies in package.json but do so at your own risk. The following worked via npm:

"overrides": {
    "@liaoliaots/nestjs-redis": {
      "@nestjs/common": "$@nestjs/common",
      "@nestjs/core": "$@nestjs/core"
    }
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants