Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bsdcpio man #1780

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update bsdcpio man #1780

wants to merge 1 commit into from

Conversation

tpgxyz
Copy link
Contributor

@tpgxyz tpgxyz commented Sep 27, 2022

Adapt bsdcpio manpage to available formats.

" --format {pwb|bin|odc|newc|ustar} Select archive format\n"

Copy link
Contributor

@kientzle kientzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this doc update. It needs a couple of small changes before we can accept it.

The SVR4 portable cpio format.
.It Ar pwb
PWB binary cpio format is the original format,
when cpio was introduced as part of the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest replacing this line with simply "from the"

@@ -50,7 +50,7 @@
.Nm
copies files between archives and directories.
This implementation can extract from tar, pax, cpio, zip, jar, ar,
and ISO 9660 cdrom images and can create tar, pax, cpio, ar,
and ISO 9660 cdrom images and can create tar, cpio, ar,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put back the reference to pax format, which is supported by bsdcpio.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kientzle Kindly please notice that pax is not available as an option

" --format {pwb|bin|odc|newc|ustar} Select archive format\n"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the help message also, it seems. In reality, that option allows any format supported by libarchive:

	r = archive_write_set_format_by_name(cpio->archive, cpio->format);

.It Ar pax
The POSIX.1 pax format, an extension of the ustar format.
.It Ar newc
The SVR4 portable cpio format.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put back the description of pax format here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants