This repository has been archived by the owner on May 14, 2020. It is now read-only.
Use type imports #253
Draft
Use type imports #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewilkybarkid
added
the
📦 Refactor
thewilkybarkid
commented
Feb 21, 2020
| import Router, { RouterContext } from '@koa/router'; | ||
| import type Router from '@koa/router'; |
There was a problem hiding this comment.
If you’ve used Flow before, the syntax is fairly similar. One difference is that we’ve added a few restrictions to avoid code that might appear ambiguous.
This is a bit annoying.
thewilkybarkid
commented
Feb 21, 2020
| @@ -4,7 +4,8 @@ | |||
| "module": "commonjs", | |||
| "outDir": "build", | |||
| "strict": true, | |||
| "esModuleInterop": true | |||
| "esModuleInterop": true, | |||
| "importsNotUsedAsValues": "error" | |||
There was a problem hiding this comment.
Better if the linter could fix these, refs typescript-eslint/typescript-eslint#1436 (comment).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript 3.8 introduced type-only imports.
Not sure if this is all the cases, and not sure what should happen with ordering (keep the same order or separate them?).