This repository has been archived by the owner on May 14, 2020. It is now read-only.
Retrieve articles from repository #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
stephenwf
reviewed
Nov 22, 2019
nlisgo
commented
Nov 26, 2019
stephenwf
reviewed
Nov 26, 2019
nlisgo
commented
Nov 26, 2019
Cooryd
reviewed
Nov 27, 2019
nlisgo
commented
Nov 27, 2019
nlisgo
commented
Nov 27, 2019
nlisgo
commented
Nov 27, 2019
src/adaptors/articles.ts
Outdated
| @@ -0,0 +1,13 @@ | |||
| import { Iri, JsonLdObj } from 'jsonld/jsonld-spec'; | |||
|
|
|||
| export default interface Articles extends Iterable<JsonLdObj> { | |||
There was a problem hiding this comment.
Following libero/publisher#346, this should probably be a Store...
This was referenced Nov 29, 2019
src/adaptors/in-memory-articles.ts
Outdated
|
|
||
| async add(node: JsonLdObj): Promise<void> { | ||
| if (node['@id'] === undefined) { | ||
| throw new InvalidId(); |
There was a problem hiding this comment.
ArticleHasNoId or something? (The ID itself isn't invalid as it doesn't exist.)
…into article-repository # Conflicts: # test/adaptors/in-memory-articles.test.ts
thewilkybarkid
approved these changes
Nov 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a retrieval process for the article listing to replace the empty hardcoded listing.