Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential Null pointer dereference in bench_httpclient.c #1609

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix potential Null pointer dereference in bench_httpclient.c #1609

wants to merge 2 commits into from

Conversation

icy17
Copy link
Contributor

@icy17 icy17 commented Apr 10, 2024

No description provided.

azat
azat reviewed Apr 15, 2024
View reviewed changes
test/bench_httpclient.c
@@ -163,7 +163,9 @@ launch_request(void)
evutil_gettimeofday(&ri->started, NULL);

b = bufferevent_socket_new(base, sock, BEV_OPT_CLOSE_ON_FREE);

if (b == NULL) {
return -1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should close the fd as well, and also let's improve the caller to print which request failed

@icy17
Copy link
Contributor Author

icy17 commented Apr 22, 2024

I just add cleanup, but I'm not sure how to "print which request failed" :(

azat
azat requested changes Apr 29, 2024
View reviewed changes
Copy link
Member

@azat azat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just add cleanup, but I'm not sure how to "print which request failed" :(

Replace perror("launch") with fprintf(stderr, "Cannot launch %i requet\n", i); and can you also please add an error path into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azat azat azat requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icy17 @azat