Improve hashsocket to avoid collisions #1646
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 91e3ead, @nmathewson "improved" the hashsocket function with a "rotate-and-add trick".
Well, while rotating the bits is fine, performing an addition on the other hand will divide by two the number of possible different hashes. With twice less possible hashes, there will be collisions. Example:
So we can keep the rotation, but we need to remove the addition for proper hashing.