fix: npe in depth shader diffuseTexture #7267
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line: https://github.com/libgdx/libgdx/blob/7fb396541a8c2777c92a5062aaa49afcab0bec1f/gdx/src/com/badlogic/gdx/graphics/g3d/shaders/DefaultShader.java#L237C32-L237C50
This is throwing an npe because the DepthShader canRender() is recycling the shader without the diffuse texture attribute.
Step to replicate: