New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pkg-config files being broken on MSVC-built static libraries #2754
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
83ad8d2
to
731ccb9
Compare
I propose to rename |
Sadly does not work well for MSVC builds where the shared import library and static one cannot coexist with the same base name. |
This is a build system-related problem. One of the possible solutions could be putting shared and static libs into different folders. Another possible solution is to provide CMake configs so P.S. I can name just a couple of libs I'm aware of that have different names for shared and static versions. It's always pain for a build system to deal with such libs as they frequently don't provide CMake configs and need runtime patching. UPDATE #2851 |
When libjxl is built as a static library with MSVC, the pkg-config files are not configured properly to account for statically-built library names, causing link failures.
This PR makes those files account for statically-built libraries that are built by MSVC.