reduce libjxl_dec binary size #2766
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsneyers
added
decoder
|
Let's just rename files. That will be less surprising for future developers... I'll prepare a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for separable 5x5 and 7x7 convolutions as well as Gaussian blurring is not used anywhere in the decoder, only in the encoder. This PR adjusts the build scripts accordingly so the decoder-only library libjxl_dec doesn't include unnecessary code.
On my x64 linux build, after stripping debug symbols, this reduces
libjxl_dec.sofrom 1456 KB to 1251 KB.