Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Stebalien a temporary admin to configure issue deletion #229

Closed
wants to merge 2 commits into from

Conversation

Stebalien
Copy link
Member

Summary

Temporary admin privledges for Stebalien to change issue deletion rules.

Why do you need this?

I'd like to configure issue deletion such that all members of the stewards group can delete issues. Otherwise, nobody but owners (as far as I can tell) can delete issues.

What else do we need to know?

I'm proposing we allow issue deletion by both "github-mgmt stewards" and "w3dt-stewards". Any objections?

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@Stebalien Stebalien requested review from a team as code owners May 12, 2024 15:43
Copy link
Contributor

The following access changes will be introduced as a result of applying the plan:

Access Changes
User stebalien:
  - will have the role in the organization change from member to admin

I'd like to configure [issue deletion](https://docs.github.com/en/organizations/managing-organization-settings/allowing-people-to-delete-issues-in-your-organization) such that all members of the stewards group can delete issues. Otherwise, nobody but owners (as far as I can tell) can delete issues.
@Stebalien Stebalien force-pushed the steb/temp-owner-issue-deletion branch from a32e384 to 77a4bd4 Compare May 12, 2024 15:50
Copy link
Contributor

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # github_membership.this["stebalien"] will be updated in-place
  ~ resource "github_membership" "this" {
        id       = "libp2p:Stebalien"
      ~ role     = "member" -> "admin"
        # (2 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@galargh
Copy link
Contributor

galargh commented May 13, 2024

This totally makes sense, I just enabled that setting for this org. Let me know if you wanted me to do the same for other orgs too, and if you want me to go ahead and merge this PR.

@Stebalien
Copy link
Member Author

Thanks! No point in merging this now.

Let me know if you wanted me to do the same for other orgs too.

Yes please!

@Stebalien Stebalien closed this May 13, 2024
@Stebalien Stebalien deleted the steb/temp-owner-issue-deletion branch May 13, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants