Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issues discovered in kubo v0.21.0-rc1 #851

Merged
merged 5 commits into from
Jun 15, 2023

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jun 15, 2023

See commit history.
Fixes #849
Closes #850

@Jorropo Jorropo requested review from a team and guillaumemichel as code owners June 15, 2023 00:53
@Jorropo
Copy link
Contributor Author

Jorropo commented Jun 15, 2023

Need go.mod update and squash

@Jorropo Jorropo marked this pull request as draft June 15, 2023 00:59
@BigLep BigLep mentioned this pull request Jun 15, 2023
@marten-seemann
Copy link
Contributor

Removing goprocess? Nice!!

Copy link
Contributor

@guillaumemichel guillaumemichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are now all green

@Jorropo Jorropo force-pushed the Jorropo/fix/leaking-goroutine branch from ae70be5 to 5bbf6ca Compare June 15, 2023 10:11
@Jorropo Jorropo marked this pull request as ready for review June 15, 2023 10:13
@github-actions
Copy link

Suggested version: v0.24.1

Comparing to: v0.24.0 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

gorelease: go: updates to go.sum needed, disabled by -mod=readonly

gocompat says:

Your branch is up to date with 'origin/master'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to master. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@Jorropo Jorropo merged commit a497df1 into master Jun 15, 2023
28 of 29 checks passed
@Jorropo Jorropo deleted the Jorropo/fix/leaking-goroutine branch June 15, 2023 10:39
Jorropo added a commit to ipfs/kubo that referenced this pull request Jun 15, 2023
Streams used to be blocked on ping IO because we didn't handled the DHT ping check asynchronously.

Include fixes from libp2p/go-libp2p-kad-dht#851
Fixes #9957
hacdias pushed a commit to ipfs/kubo that referenced this pull request Jun 15, 2023
Streams used to be blocked on ping IO because we didn't handled the DHT ping check asynchronously.

Include fixes from libp2p/go-libp2p-kad-dht#851
Fixes #9957
hacdias pushed a commit to ipfs/kubo that referenced this pull request Jun 15, 2023
Streams used to be blocked on ping IO because we didn't handled the DHT ping check asynchronously.

Include fixes from libp2p/go-libp2p-kad-dht#851
Fixes #9957
hacdias pushed a commit to ipfs/kubo that referenced this pull request Jun 15, 2023
Streams used to be blocked on ping IO because we didn't handled the DHT ping check asynchronously.

Include fixes from libp2p/go-libp2p-kad-dht#851
Fixes #9957
hacdias pushed a commit to ipfs/kubo that referenced this pull request Jun 15, 2023
Streams used to be blocked on ping IO because we didn't handled the DHT ping check asynchronously.

Include fixes from libp2p/go-libp2p-kad-dht#851
Fixes #9957
hannahhoward pushed a commit to filecoin-project/kubo-api-client that referenced this pull request Jun 19, 2023
Streams used to be blocked on ping IO because we didn't handled the DHT ping check asynchronously.

Include fixes from libp2p/go-libp2p-kad-dht#851
Fixes #9957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug/regression: goroutine leak
3 participants