Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps #2332

Merged
merged 2 commits into from Jun 9, 2023
Merged

chore: update deps #2332

merged 2 commits into from Jun 9, 2023

Conversation

marten-seemann
Copy link
Contributor

For the v0.28 release.

@sukunrt
Copy link
Member

sukunrt commented Jun 5, 2023

we need to revert the prometheus version upgrade or fix all metrics tests to allow 1 allocation. The new version allocates always.
This is the line in the PR that introduced this. https://github.com/prometheus/client_golang/pull/1151/files#diff-6c26c389818dfee2d79536851616151d3b7e8a94667ee77f8d23ec694f4a8a61R662

There is a PR to fix this:
prometheus/client_golang#1272

@marten-seemann marten-seemann mentioned this pull request Jun 8, 2023
@sukunrt sukunrt merged commit 1b0df37 into master Jun 9, 2023
19 checks passed
@sukunrt sukunrt deleted the update-deps-for-v028 branch June 9, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants