webrtc: add a test for establishing many connections #2801
+99
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
webrtc-fix
branch
4 times, most recently
from
ad84c06
to
8fcca64
Compare
sukunrt
commented
May 21, 2024
Comment on lines
+332
to
+333
| pc.OnConnectionStateChange(func(_ webrtc.PeerConnectionState) { | ||
| switch pc.ConnectionState() { |
There was a problem hiding this comment.
This works fine, but the change makes it better in case there are ordering issues for the callback. The callback does need to guarantee that we can access connection state.
There was a problem hiding this comment.
Apparently it doesn't work fine. pion/webrtc#2702 (comment)
So we do need this change.
sukunrt
force-pushed
the
webrtc-fix
branch
2 times, most recently
from
24f7760
to
5a485d6
Compare
MarcoPolo
reviewed
May 28, 2024
| return | ||
| } | ||
| s.Write(b[:]) | ||
| s.Read(b[:]) // peer will close the connection after read |
There was a problem hiding this comment.
Should we expect an error here then?
sukunrt
force-pushed
the
webrtc-fix
branch
2 times, most recently
from
3c3731a
to
64836ad
Compare
sukunrt
changed the title
sukunrt
force-pushed
the
webrtc-fix
branch
2 times, most recently
from
22aa5d5
to
a611a26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.