feat: support delegated value store in content-routing module #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusefnapora
commented
Oct 7, 2021
| @@ -149,7 +148,7 @@ | |||
| "it-pushable": "^1.4.0", | |||
| "libp2p": ".", | |||
| "libp2p-bootstrap": "^0.13.0", | |||
| "libp2p-delegated-content-routing": "^0.11.0", | |||
| "libp2p-delegated-content-routing": "git+ssh://git@github.com/libp2p/js-libp2p-delegated-content-routing#362cd00988e717f6fc49b0a1f2fa7bbaabbfcc53", | |||
There was a problem hiding this comment.
This will need to be updated once the dependent PR is merged
|
Moving this to draft until we're able to give a concerted effort on IPNS improvements as part of ipfs/js-ipfs#2921 |
achingbrain
force-pushed
the
main
branch
17 times, most recently
from
05c6ace
to
bd30ffd
Compare
achingbrain
force-pushed
the
main
branch
20 times, most recently
from
242fd96
to
bca8d6e
Compare
|
Closing as this can be implemented by specifying additional content routers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for delegated
put/getoperations in thecontent-routingmodule instead of always using the DHT. It depends on some in-progress PRs, so CI is currently failing.Dependencies:
To run the tests locally, you can checkout the PR branch of
js-libp2p-interfacesandnpm linkit into js-libp2p. For now, I'm depending on a commit hash for the delegated-content-routing PR, but that doesn't work for libp2p-interfaces since it's a multi-module repo.This adds a new entry to the config
modulesobject calledvalueStoragewhich can containValueStoreimplementations. Currently the only non-DHT implementation is in the delegated-content-routing PR above.I don't think the config change is technically a breaking API change since it's additive - if you don't add the new valueStorage module in your config you just won't get delegated put/get operations, but the DHT will still work if you've enabled it.