Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configuration validation #2133

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

feat: configuration validation #2133

wants to merge 25 commits into from

Conversation

achingbrain
Copy link
Member

Closes #1573
Closes #1757
Closes #1903

I decided to go with yup for a few reasons:

  • Integration was more seamless
  • Is used by substantially more projects ( 545k vs 105k)
  • Preferred the schema building via chaining as opposed to defining complex functions (especially for defining integers, mins and defaults)
  • Was more actively maintained ( most recent commit 3 weeks ago as opposed to last year November
  • More downloads ( 4,201,246 vs 889,754 weekly downloads)

@maschad @SgtPooki @achingbrain
feat: configuration validation (#1778)
0f394b3 
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
@achingbrain achingbrain requested a review from a team as a code owner October 6, 2023 08:40
@achingbrain achingbrain mentioned this pull request Oct 6, 2023
Merged
wemeetagain
wemeetagain requested changes Oct 9, 2023
View reviewed changes
packages/libp2p/src/config/helpers.ts Outdated Show resolved Hide resolved
packages/libp2p/src/autonat/index.ts Outdated Show resolved Hide resolved
packages/libp2p/src/circuit-relay/server/index.ts Outdated Show resolved Hide resolved
packages/libp2p/src/connection-manager/utils.ts Outdated Show resolved Hide resolved
packages/libp2p/src/connection-manager/utils.ts Outdated Show resolved Hide resolved
packages/libp2p/src/dcutr/dcutr.ts Outdated Show resolved Hide resolved
packages/libp2p/src/fetch/index.ts Outdated Show resolved Hide resolved
packages/libp2p/src/identify/identify.ts Outdated Show resolved Hide resolved
packages/libp2p/src/ping/index.ts Outdated Show resolved Hide resolved
packages/libp2p/src/upnp-nat/index.ts Outdated Show resolved Hide resolved
@maschad maschad marked this pull request as draft November 21, 2023 03:43
@maschad maschad marked this pull request as ready for review November 24, 2023 04:12
wemeetagain
wemeetagain reviewed Nov 27, 2023
View reviewed changes
packages/libp2p/src/connection-manager/utils.ts Outdated Show resolved Hide resolved
packages/libp2p/src/address-manager/utils.ts Outdated Show resolved Hide resolved
packages/libp2p/src/config/config.ts Outdated Show resolved Hide resolved
packages/protocol-dcutr/src/dcutr.ts Outdated Show resolved Hide resolved
packages/protocol-dcutr/src/dcutr.ts Outdated Show resolved Hide resolved
packages/libp2p/src/connection-manager/utils.ts Show resolved Hide resolved
@dhuseby dhuseby mentioned this pull request Apr 30, 2024
Open
@SgtPooki SgtPooki mentioned this pull request May 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad approved these changes

@wemeetagain wemeetagain Awaiting requested review from wemeetagain

Assignees
No one assigned
Labels
None yet
Projects
js-libp2p
Status: 🛠️ Todo
Milestone
No milestone
3 participants
@achingbrain @wemeetagain @maschad