Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add private key to libp2p components #2303

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

wemeetagain
Copy link
Member

Description

  • Add privateKey to Components and use it where possible
  • Update pubsub, identify, circuit-relay v2, record envelope sealing to use privateKey instead of peerId

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

BREAKING CHANGE:

  • IdentifyComponents now includes a privateKey
  • PubSubComponents now includes a privateKey
  • CircuitRelayServerComponents now includes a privateKey
  • RecordEnvelope.seal now has a privateKey as the second param rather than a peerId
  • RecordEnvelope constructor now takes a publicKey

@wemeetagain wemeetagain requested a review from a team as a code owner December 5, 2023 21:41
@achingbrain
Copy link
Member

Is there a way we can do this in stages to prevent it causing libp2p v2? Perhaps just adding the private key in the first instance, then releasing it, then upgrading noise etc to use it?

achingbrain added a commit that referenced this pull request Jan 16, 2024
- Add `privateKey` to `Components`
- Non-breaking version of #2303

---------

Co-authored-by: Alex Potsides <alex@achingbrain.net>
Co-authored-by: chad <chad.nehemiah94@gmail.com>
@dhuseby dhuseby added the version-2.0 PRs that will be released in libp2p v2 label May 21, 2024
@dhuseby
Copy link
Contributor

dhuseby commented May 21, 2024

Blocked waiting for the next breaking release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version-2.0 PRs that will be released in libp2p v2
Projects
Status: 🧱Blocked
Development

Successfully merging this pull request may close these issues.

None yet

3 participants