Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically we've not tried to close connections after they've been opened because we let the connection pruner do that when it's required.
This leads to high resource usage and requires the pruner to be able to select the best connections for pruning which without the context of their intended use is a guessing game.
A distinction is drawn between protocols that have a definite purpose (e.g. kad-dht) and "speculative" protocols that are run on newly opened connections for other purposes, e.g. identify, auto nat, etc.
For example if kad-dht opens a connection to send a message, we can close that connection if the only protocol running on it is identify.
Change checklist