Do not add addresses if they are already there in peerdata #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhchia
reviewed
Oct 14, 2019
Comment on lines
+29
to
+31
| for addr in addrs: | ||
| if addr not in self.addrs: | ||
| self.addrs.append(addr) |
There was a problem hiding this comment.
What I'm thinking is probably we should change addrs from List[Multiaddr] to Set[Multiaddr] to reduce time complexity.
However, this solution works for me so far. 👍
Edited: removed the thought on replacing List with Set since it is already mentioned in the PR.
|
i'd suggest we use a do you want to update the PR @moshemalawach ? if not, i'll move this to a tracking issue and we can go ahead and merge this in. |
|
and +1 on a test for this scenario :) |
pyaleph depends on this version of `py-libp2p` and on `py-substrate-interface`. `py-substrate-interface` requires `base58>=2.0.1`, which conflicts with the dependency on `base58>=1.0.3,<2.0.0` in this setup.py.
Fix dependency issue on base58 with pyaleph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In peerdata, if you call add_addrs, the function doesn't check if the addresses are already there.
This can result in the list growing huge if we reconnect often to the same hosts.
An alternative solution to the one proposed would be to change self.addrs to a set and not a list. But that would need some work in places where we use addrs[0] (like in swarm).