Add udp #327
Add udp #327
Conversation
| self._stream.close() | ||
| # TODO: Correct way to destroy all handlers? | ||
| for task in self._running_handlers: | ||
| task.cancel() |
There was a problem hiding this comment.
The proper pattern here according to the asyncio docs is:
task.cancel()
try:
await task
except asyncio.CancelledError:
passThis gives the loop the opportunity to inject the cancellation exception into the task so that it doesn't end up being reported as an unretrieved exception.
There was a problem hiding this comment.
Thanks! I missed it. And probably there are more bugs, I wrote it without much revising.
|
This is still just a "prototype" of what could be a UDP implementation. I just made the pull request for being easily referable from the issue. |
|
Sorry for closing @pipermerriam I was browsing on the phone, and I hit "Close and comment" accidentally. |
If you would like to work on that I'd be happy to help in any way I can. That could be reviewing pull requests, funding a small grant, etc. |
We should first check how asyncio compatibility would work, because most people use asyncio. Or which limitations/difficulties may arise. However, I think, Trio's sockets API (apart from Nursery) are much better than asyncio's. And even more for getting a Unified Interface for TCP and UDP. |
|
The plan would be to drop compatibility with |
Removed 'drain' from Stream unified interface Linted Linted Fixed little ineffiencies, and added bit of documentation Fixed ServerStream closing With previous implementation, when you closed the stream, you closed the stream shared by all UDP handlers from the same Server Fixed inconsistent method resolution in UDP Streams Linted
This is the code related to UDP implementation, where it is trying to Resolve #326 .