-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to save posts (Addresses #81) #391
base: master
Are you sure you want to change the base?
Conversation
hamiltondave
commented
Jan 10, 2022
- Addresses Feature Request | Save posts #81
- Added a star SVG icon at the bottom of posts which will allow users to save or unsave it
- List of saved posts is stored in a cookie
- Saved posts can be viewed at /saved, which is linked in the feeds dropdown
Nice to see this addressed! Do saved posts work with:
Also are you able to save individual comments, not just parent threads? |
Thanks for taking a look at this. I just updated the branch so that saved posts can be restored with the link on the settings page. This just works for parent threads for now though. |
Can you rebase your changes on latest master? I want to give this feature a try |
f8b4f40
to
6c551f0
Compare
This is rebased now and ready to test. |
I gave this PR a try. There's some stuff I see an issue with:
|
Thanks for your feedback! I think this is all doable. I will work on these improvements when I have some time. |
Another thing I noticed is that when you submit the |
@hamiltondave: Now that Libreddit development has resumed, I'd like us to consider this for inclusion in the code base. Would you mind pulling the latest from master and resolving merge conflicts? Keep in mind that with the merge of #637 the template block that generates the view for a post has been made a macro and moved into |