Make the fixed navbar optional #536
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds another on/off preference (default: on, keeps same behaviour) for the fixed navbar. When off the navbar will not remain at the top of the page when scrolling. This is useful for small displays such as phones where otherwise the navbar takes up a sizeable portion of the viewport.
|
ping @spikecodes @sigaloid Thanks for your contribution. Sorry it's taken us a while before we got a change to review. I'm unopposed to this and willing to bring this in (pending the merge conflict resolution), but I'll also let the other two project heads chime in to see what they say. |
|
I too am unopposed. 😄 🦀 thanks for your first contribution, I hope to see this go in soon! |
spikecodes
approved these changes
Jan 1, 2023
|
Introducing #662 into master has given rise to a merge conflict in this PR. I'll take care of it as part of the merge. |
|
I haven't forgotten about this. I'll try to get to this this week. |
Scratchcat1
force-pushed
the
feature/fixed-navbar
branch
from
58cf16e
to
48fd4be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds another on/off preference (default: on, keeps same behaviour) for the fixed navbar.
When off the navbar will not remain at the top of the page when scrolling.
This is useful for small displays such as phones where otherwise the navbar takes up a sizeable portion of the viewport.