Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link to reddit status page. #753

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikupls
Copy link
Contributor

@mikupls mikupls commented Mar 14, 2023

Reddit is down. Good opportunity to make the error page slightly more nice to use.

Preview:
pic123

@mikupls
Copy link
Contributor Author

mikupls commented Mar 14, 2023

I realize the error page is a bit overloaded in use (i.e. there are many paths that lead to the error page). Many of these paths point to some problem with reddit though, and it didn't feel worth to refactor everything for a small link that is likely useful in most cases.

Copy link
Member

@sigaloid sigaloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks for the PR!

@@ -4,6 +4,8 @@
{% block content %}
<div id="error">
<h1>{{ msg }}</h1>
<h3><a href="https://www.redditstatus.com/">Reddit Status</a></h3>
<br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<br>
<br />

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start, but remember that template is used for conveying any class of error we get from Reddit (i.e. any response with codes in the 400-5xx range). See the function error in src/utils.rs.

Ideally, we should instruct the user to visit https://redditstatus.com/ when Reddit responds to requests with 5xx's, and not 4xx's. The latter case will happen, for example, when a user attempts to view a banned subreddit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants