-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add link to reddit status page. #753
base: master
Are you sure you want to change the base?
Conversation
I realize the error page is a bit overloaded in use (i.e. there are many paths that lead to the error page). Many of these paths point to some problem with reddit though, and it didn't feel worth to refactor everything for a small link that is likely useful in most cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks for the PR!
@@ -4,6 +4,8 @@ | |||
{% block content %} | |||
<div id="error"> | |||
<h1>{{ msg }}</h1> | |||
<h3><a href="https://www.redditstatus.com/">Reddit Status</a></h3> | |||
<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<br> | |
<br /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start, but remember that template is used for conveying any class of error we get from Reddit (i.e. any response with codes in the 400-5xx range). See the function error
in src/utils.rs
.
Ideally, we should instruct the user to visit https://redditstatus.com/ when Reddit responds to requests with 5xx's, and not 4xx's. The latter case will happen, for example, when a user attempts to view a banned subreddit.
Reddit is down. Good opportunity to make the error page slightly more nice to use.
Preview: