Fixing a potential typo in a function name - getCurrentWorkspace-> useCurrentModule
#2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is stale because it has been open for 2 days with no activity. |
chartgerink
approved these changes
May 27, 2024
There was a problem hiding this comment.
Thanks @nsunami 馃槃 And sorry for the limited responsiveness again - I keep losing track of my notifications as github gets clogged with my dayjob 馃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chartgerink This is a super tiny fix, but I noticed that the function name in useCurrentModule is now getCurrentWorkspace. It's a default export. As far as I can see, other modules import this as "useCurrentModule".
We could also change to "getCurrentModule" (since the prefix use can imply that it will return an array output from useState), but then it's a bit of nitpicky detail, so I just suggest this change for consistency only for now. 馃