Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unix,win: fix threadpool race condition #2021

Closed
wants to merge 1 commit into from

Commits on Oct 4, 2018

  1. unix,win: fix threadpool race condition

    90891b4 introduced a race
    condition when accessing `slow_io_work_running` – it is being
    increased and later decreased as part of the worker thread loop,
    but was accessed with different mutexes during these operations.
    
    This fixes the race condition by making sure both accesses
    are protected through the global `mutex` of `threadpool.c`.
    
    This fixes a number of flaky Node.js tests.
    
    Refs: libuv#1845
    Refs: nodejs/reliability#18
    Refs: nodejs/node#23089
    Refs: nodejs/node#23067
    Refs: nodejs/node#23066
    Refs: nodejs/node#23219
    addaleax committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    28139bf View commit details
    Browse the repository at this point in the history