src: fill sockaddr_in6.sin6_len when it's defined #2189
Closed
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As some calls in some platforms require.
|
Is this a problem IRL? In the example the check would succeed because sin6_family is set properly, wouldn't it? |
|
It returns |
|
And I've met this issue while trying to bring #964 up to date. |
|
Doh, sorry, I read that wrong... |
saghul
approved these changes
Feb 14, 2019
cjihrig
approved these changes
Feb 14, 2019
bnoordhuis
approved these changes
Feb 14, 2019
| @@ -222,6 +222,9 @@ int uv_ip6_addr(const char* ip, int port, struct sockaddr_in6* addr) { | |||
| memset(addr, 0, sizeof(*addr)); | |||
| addr->sin6_family = AF_INET6; | |||
| addr->sin6_port = htons(port); | |||
| #ifdef SIN6_LEN | |||
| addr->sin6_len = sizeof(struct sockaddr_in6); | |||
There was a problem hiding this comment.
sizeof(*addr) for consistency with other sizeof expressions?
santigimeno
added a commit
that referenced
this pull request
Feb 16, 2019
As some calls in some platforms require. PR-URL: #2189 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in 98db184 incorporating Ben's suggestion. Thanks |
njlr
pushed a commit
to buckaroo-pm/libuv
that referenced
this pull request
Apr 5, 2019
As some calls in some platforms require. PR-URL: libuv#2189 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As some calls in some platforms require.
Example
CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1231/