Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win,tty: fix deadlock caused by inconsistent state #2882

Closed
wants to merge 1 commit into from
Closed

win,tty: fix deadlock caused by inconsistent state #2882

wants to merge 1 commit into from

Commits on Jun 11, 2020

  1. win,tty: fix deadlock caused by inconsistent state 

    The variable uv__read_console_status is left as IN_PROGRESS when the
operation is cancelled ahead of time by the main thread requesting a
trap (race condition?).

This confuses the next call to uv__cancel_read_console(...) causing
a deadlock due to a semaphore aquisition that is never released by
the reading thread.

Setting the status variable back to COMPLETE or NOT_STARTED fixes
the issue.

Fixes: nodejs/node#32999
    @lander0s
    lander0s committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    1a05b46 View commit details
    Browse the repository at this point in the history