unix: check for EXDEV for uv__fs_copy_file_range #3108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copy_file_range will not work when in_fd and out_fd are not on the same mounted filesystem (pre Linux 5.3). Fixes: nodejs/node#37284 Refs: https://www.man7.org/linux/man-pages/man2/copy_file_range.2.html#ERRORS
cjihrig
reviewed
Feb 13, 2021
src/unix/fs.c
Outdated
| @@ -929,6 +929,11 @@ static ssize_t uv__fs_sendfile(uv_fs_t* req) { | |||
| } else if (r == -1 && errno == ENOTSUP) { | |||
| /* ENOTSUP - it could work on another file system type */ | |||
| errno = 0; | |||
| } else if (r == -1 && errno == EXDEV) { | |||
There was a problem hiding this comment.
I think you can combine this with the previous else if:
} else if (r == -1 && (errno == ENOTSUP || errno == EXDEV)) {
There was a problem hiding this comment.
@cjihrig I combined the checks. PTAL.
cjihrig
approved these changes
Feb 13, 2021
There was a problem hiding this comment.
LGTM. CI seems fine as well: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/2126/
richardlau
approved these changes
Feb 13, 2021
cjihrig
pushed a commit
that referenced
this pull request
Feb 13, 2021
copy_file_range will not work when in_fd and out_fd are not on the same mounted filesystem (pre Linux 5.3). Refs: nodejs/node#37284 PR-URL: #3108 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
|
Landed in 70f67d8. Thanks! |
JeffroMF
pushed a commit
to JeffroMF/libuv
that referenced
this pull request
May 16, 2022
copy_file_range will not work when in_fd and out_fd are not on the same mounted filesystem (pre Linux 5.3). Refs: nodejs/node#37284 PR-URL: libuv#3108 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy_file_rangewill not work whenin_fdandout_fdare not on the same mounted filesystem (pre Linux 5.3).
Fixes: nodejs/node#37284
Refs: https://www.man7.org/linux/man-pages/man2/copy_file_range.2.html#ERRORS