Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup GitHub Actions to produce Windows binary on release tag creation #3194

Open
wants to merge 54 commits into
base: v1.x
Choose a base branch
from

Conversation

TheTechsTech
Copy link

  • In reference to Download binaries? #1042, seems there should be one Windows location for binaries based on original and any changes.

.github/workflows/release-windows.yml Outdated Show resolved Hide resolved
.github/workflows/release-windows.yml Outdated Show resolved Hide resolved
.github/workflows/release-windows.yml Outdated Show resolved Hide resolved
@stale stale bot added the stale label Jul 29, 2021
@stale stale bot removed the stale label Oct 7, 2021
@libuv libuv deleted a comment from stale bot Oct 17, 2021
@bnoordhuis
Copy link
Member

@libuv/windows This needs your input. The changes look okay to my untrained eye.

@vtjnash
Copy link
Member

vtjnash commented Oct 18, 2021

I feel neutral-to-slightly-negatively towards maintaining binaries, but for no particular reason, just that I don't want to deal with them.

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Jan 9, 2022
@stale stale bot removed the stale label Apr 14, 2022
TheTechsTech and others added 24 commits March 24, 2023 15:22
name: windows-build
runs-on: windows-latest
steps:
- uses: actions/checkout@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use v4

.github/workflows/release-windows.yml Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants