Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App does not capture 12-character full game IDs #2291

Open
jas14 opened this issue Jan 26, 2023 · 1 comment · May be fixed by #2299
Open

App does not capture 12-character full game IDs #2291

jas14 opened this issue Jan 26, 2023 · 1 comment · May be fixed by #2299

Comments

@jas14
Copy link
Collaborator

jas14 commented Jan 26, 2023

Current situation

Games are identified by 8 characters. However, these 8 characters can be proceeded by another 4 characters indicating the player POV (essentially, white or black). URLs with these full game IDs are often shared from desktop or mobile web, since they're contained in the browser URL at the end of (or during) a game.

The app does not intercept this 12-character full game ID, so visiting such a link on mobile will direct you to whatever browser is installed instead of the native app experience.

Suggestion

Intercept this app link and open the corresponding game, showing the corresponding perspective.

On desktop, when someone visits a URL with a POV that's not actually their own, they're redirected to the appropriate path, which is /<gameId>/<color> (or, in the case of white, just /<gameId>). Unfortunately, that is not the case when accessing the game via the API, but I imagine with a little server-side work, the API could return a reference to the game ID and the appropriate color perspective.

@jas14
Copy link
Collaborator Author

jas14 commented Jan 26, 2023

I've been informed that the last char is in [0-4A-Z] if white, and [5-9a-z] if black, so we don't even need to ask the server to decode the last 4 characters for us.

@jas14 jas14 linked a pull request Jan 29, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant