Add 12-character game link support #2299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess I should merge it when the apple-app-site-association is updated on Lila. |
jas14
force-pushed
the
full-game-id-support
branch
from
89ea8a8
to
1c98d47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2291. This should do the trick for Android, but we will need to update apple-app-site-associations on lila for iOS.
I tested on an Android emulator using the following command:
and substituted various URIs, including:
https://lichess.org/2360tJXP000Z#50(White's perspective at ply 50)https://lichess.org/2360tJXP000Z(White's perspective, no ply)https://lichess.org/2360tJXP000z(Black's perspective, no ply)and some of the other link variations with just 8-character game IDs.