-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User full game list #572
User full game list #572
Conversation
Currently we are downloading all game histories at once, which takes a very long time to load on startup if the user has a large number of games. We will need a pagination api to get a few games everytime. |
Hello! Pagination is indeed mandatory, even for a first version. |
Pagination is now implemented! 🚀 |
Hello @ZTL-UwU, accuracy should prob be fetched as well similar to the recent game list, thoughts? |
The accuracy should be fetched, yes. Problem is that the server API only return a |
@ZTL-UwU I think we should merge this PR with its current implementation (so without filters and bookmark action). The rest can be done later. Could you resolve the conflicts please, then I'll review asap. Thanks! |
Signed-off-by: ZTL-UwU <zhangtianli2006@163.com>
Signed-off-by: ZTL-UwU <zhangtianli2006@163.com>
Signed-off-by: ZTL-UwU <zhangtianli2006@163.com>
use default ios navigation bar previousPage remove wrong comment
Signed-off-by: ZTL-UwU <zhangtianli2006@163.com>
Signed-off-by: ZTL-UwU <zhangtianli2006@163.com>
Thanks for making the change @ZTL-UwU , I just realised you updated the PR. Will take take of it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is starting to look good now!
As you may have noticed, now the recent games section include offline games too. Pagination support is already done in the GameStorage
class, so it should be pretty straightforward now to include the offline games in full game list when having no connectivity.
Using same logic as in
final recentGames = user != null |
…x typo Signed-off-by: ZTL-UwU <zhangtianli2006@163.com>
Clear engine suggestion arrows after reaching checkmate or stalemate
Signed-off-by: ZTL-UwU <zhangtianli2006@163.com>
Signed-off-by: ZTL-UwU <zhangtianli2006@163.com>
Signed-off-by: ZTL-UwU <zhangtianli2006@163.com>
Signed-off-by: ZTL-UwU <zhangtianli2006@163.com>
…to ZTL-UwU-full-game-list
Thanks for your work. I pushed some refactoring, I'll continue to work a bit on it but I think we're close to merging this :) |
By the way, each time I push to a remote repository branch, it messes up the diff. I don't know what I'm doing wrong...
EDIT: oh, I suppose it is because of the merge commit. But GitHub command line instructions doesn't work without it. |
🎉 |
TODO
Current status