#341: Fixes for type-parameters without arguments #346
+255
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 22, 2022 15:59
…e List[str], List, list)
* Added new internal helper type `core._NoArgs` and its singleton instance `core._NO_ARGS` * Added new methods `core._extract_args()` and `core._extract_type_parameter()` which return either `tp.__args__` value or `_NO_ARGS` constant * All "unsafe" usages of `tp.__args__` replaced with the new methods * Still fails with few tests on Python 3.6-3.8, no longer fails on Python 3.9+
…s None (Python 3.6 only)
…xtract_args()` (Python 3.6 only)
USSX-Hares
changed the title
added 2 commits
March 23, 2022 02:47
…me them according to the naming convention
|
This seems like a pretty solid thing to get into the project so it is working in 3.10 as well :) |
|
Yes I'm sorry I've been MIA... I'll take a look soon! |
lidatong
approved these changes
Aug 14, 2022
|
@lidatong do you have plans to release a new version with this patch in? It will be great if we can get this bug fixed |
|
@lidatong any update on this? Would be great to have a new version released with these features. |
renovate bot
referenced
this pull request
in ixm-one/pytest-cmake-presets
Jun 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [dataclasses-json](https://togithub.com/lidatong/dataclasses-json) | `0.5.7` -> `0.5.8` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>lidatong/dataclasses-json</summary> ### [`v0.5.8`](https://togithub.com/lidatong/dataclasses-json/releases/tag/v0.5.8) [Compare Source](https://togithub.com/lidatong/dataclasses-json/compare/v0.5.7...v0.5.8) #### What's Changed - [#​341](https://togithub.com/lidatong/dataclasses-json/issues/341): Fixes for type-parameters without arguments by [@​USSX-Hares](https://togithub.com/USSX-Hares) in [https://github.com/lidatong/dataclasses-json/pull/346](https://togithub.com/lidatong/dataclasses-json/pull/346) - ci: disable 3.6 by [@​lidatong](https://togithub.com/lidatong) in [https://github.com/lidatong/dataclasses-json/pull/400](https://togithub.com/lidatong/dataclasses-json/pull/400) - ci: bump gh action by [@​lidatong](https://togithub.com/lidatong) in [https://github.com/lidatong/dataclasses-json/pull/403](https://togithub.com/lidatong/dataclasses-json/pull/403) - Update usage of mypy.main in test following updates to mypy package by [@​rpmcginty](https://togithub.com/rpmcginty) in [https://github.com/lidatong/dataclasses-json/pull/374](https://togithub.com/lidatong/dataclasses-json/pull/374) - Fixes recursive dict encoding by [@​matt035343](https://togithub.com/matt035343) in [https://github.com/lidatong/dataclasses-json/pull/394](https://togithub.com/lidatong/dataclasses-json/pull/394) - Removes unused type variables in api.py by [@​matt035343](https://togithub.com/matt035343) in [https://github.com/lidatong/dataclasses-json/pull/415](https://togithub.com/lidatong/dataclasses-json/pull/415) - Documentation: added example of global_config by [@​nr23](https://togithub.com/nr23) in [https://github.com/lidatong/dataclasses-json/pull/189](https://togithub.com/lidatong/dataclasses-json/pull/189) - ci: add publish to gh action workflow by [@​lidatong](https://togithub.com/lidatong) in [https://github.com/lidatong/dataclasses-json/pull/421](https://togithub.com/lidatong/dataclasses-json/pull/421) #### New Contributors - [@​rpmcginty](https://togithub.com/rpmcginty) made their first contribution in [https://github.com/lidatong/dataclasses-json/pull/374](https://togithub.com/lidatong/dataclasses-json/pull/374) - [@​matt035343](https://togithub.com/matt035343) made their first contribution in [https://github.com/lidatong/dataclasses-json/pull/394](https://togithub.com/lidatong/dataclasses-json/pull/394) - [@​nr23](https://togithub.com/nr23) made their first contribution in [https://github.com/lidatong/dataclasses-json/pull/189](https://togithub.com/lidatong/dataclasses-json/pull/189) **Full Changelog**: lidatong/dataclasses-json@v0.5.7...v0.5.8 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
This was referenced Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #341
Changes:
tests.entitiesandtests.test_collectionsto include alternative forms of the same collection types(like
builtins.list("builtin") andtyping.List("generic""unbound") in addition to the existingtyping.List[TypeA])core._NoArgsutils._NoArgsand its singleton instancecore._NO_ARGSutils._NO_ARGScore._extract_args()utils._get_type_args()andcore._extract_type_parameter()utils._get_type_arg_param()which return eithertp.__args__value or_NO_ARGSconstanttp.__args__replaced with the new methodsTypeVarspecial case check forcore._decode_dict_keys()By some reason, "unbound" dicts are counted as having key type parameter to be
TypeVar('KT')tp.__origin__ == Nonespecial case forutils._get_type_origin()By some reason, some "unbound" types (
typing.Set,typing.Tuple, andtyping.FrozenSet) are considered to have this field withNonerather than generating anAttributeErrortp.__args__and dictsStatus
typingmodule types without parameters broken when using Python 3.9 #341)tp.__args__:Decodes "unbound" (but not "builtin") sets, tuples, and frozensets as lists rather than required typesFails to decode "unbound" and "builtin" dicts by trying to instantiate uninstantiatabletyping.Dict.Was actually caused by the strange structure of dict class nesting in specifically these Python versions, see note above
Unable to decode "unbound"typing.Dictanddictkeys on Python 3.6 exclusively