Fixes recursive dict encoding #394
Merged
+22
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't this still fail on dicts and lists with more than one level of nesting? I believe this type check should be done in |
You are absolutely right. I have now fixed it and changed the test to catch this case as well. |
|
@matt035343 could you sync your branch with master, so CI runs again w/o py3.6? |
george-zubrienko
approved these changes
Jun 6, 2023
renovate bot
referenced
this pull request
in ixm-one/pytest-cmake-presets
Jun 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [dataclasses-json](https://togithub.com/lidatong/dataclasses-json) | `0.5.7` -> `0.5.8` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>lidatong/dataclasses-json</summary> ### [`v0.5.8`](https://togithub.com/lidatong/dataclasses-json/releases/tag/v0.5.8) [Compare Source](https://togithub.com/lidatong/dataclasses-json/compare/v0.5.7...v0.5.8) #### What's Changed - [#​341](https://togithub.com/lidatong/dataclasses-json/issues/341): Fixes for type-parameters without arguments by [@​USSX-Hares](https://togithub.com/USSX-Hares) in [https://github.com/lidatong/dataclasses-json/pull/346](https://togithub.com/lidatong/dataclasses-json/pull/346) - ci: disable 3.6 by [@​lidatong](https://togithub.com/lidatong) in [https://github.com/lidatong/dataclasses-json/pull/400](https://togithub.com/lidatong/dataclasses-json/pull/400) - ci: bump gh action by [@​lidatong](https://togithub.com/lidatong) in [https://github.com/lidatong/dataclasses-json/pull/403](https://togithub.com/lidatong/dataclasses-json/pull/403) - Update usage of mypy.main in test following updates to mypy package by [@​rpmcginty](https://togithub.com/rpmcginty) in [https://github.com/lidatong/dataclasses-json/pull/374](https://togithub.com/lidatong/dataclasses-json/pull/374) - Fixes recursive dict encoding by [@​matt035343](https://togithub.com/matt035343) in [https://github.com/lidatong/dataclasses-json/pull/394](https://togithub.com/lidatong/dataclasses-json/pull/394) - Removes unused type variables in api.py by [@​matt035343](https://togithub.com/matt035343) in [https://github.com/lidatong/dataclasses-json/pull/415](https://togithub.com/lidatong/dataclasses-json/pull/415) - Documentation: added example of global_config by [@​nr23](https://togithub.com/nr23) in [https://github.com/lidatong/dataclasses-json/pull/189](https://togithub.com/lidatong/dataclasses-json/pull/189) - ci: add publish to gh action workflow by [@​lidatong](https://togithub.com/lidatong) in [https://github.com/lidatong/dataclasses-json/pull/421](https://togithub.com/lidatong/dataclasses-json/pull/421) #### New Contributors - [@​rpmcginty](https://togithub.com/rpmcginty) made their first contribution in [https://github.com/lidatong/dataclasses-json/pull/374](https://togithub.com/lidatong/dataclasses-json/pull/374) - [@​matt035343](https://togithub.com/matt035343) made their first contribution in [https://github.com/lidatong/dataclasses-json/pull/394](https://togithub.com/lidatong/dataclasses-json/pull/394) - [@​nr23](https://togithub.com/nr23) made their first contribution in [https://github.com/lidatong/dataclasses-json/pull/189](https://togithub.com/lidatong/dataclasses-json/pull/189) **Full Changelog**: lidatong/dataclasses-json@v0.5.7...v0.5.8 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #391, please refer to this issue for a detailed description of what is fixed in this pull request.
I implemented both a fix to the encoding and added tests that will capture the behaviour.