Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [experiment] check signals v1 #114

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

🚨 [experiment] check signals v1 #114

wants to merge 3 commits into from

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Apr 30, 2024

Checking drop-in reactivity pipeline replacement with signals polyfill

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit 652e2f4
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/66313c7eb4d45e0008c1dadc
😎 Deploy Preview https://deploy-preview-114--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

duration phase estimated regression +9376ms [9317ms to 9439ms] OR +291.32% [289.51% to 293.29%]
renderEnd phase no difference [0ms to 0ms]
render1000Items1End phase estimated regression +20ms [17ms to 22ms] OR +9.93% [8.73% to 11.13%]
clearItems1End phase estimated regression +173ms [167ms to 177ms] OR +542.39% [522.08% to 553.14%]
render1000Items2End phase estimated regression +27ms [17ms to 33ms] OR +18.06% [11.42% to 22.14%]
clearItems2End phase estimated regression +166ms [160ms to 168ms] OR +506.97% [486.74% to 510.76%]
render5000Items1End phase estimated regression +58ms [50ms to 67ms] OR +7.42% [6.4% to 8.47%]
clearManyItems1End phase estimated regression +3750ms [3727ms to 3783ms] OR +3214.31% [3194.71% to 3242.69%]
render5000Items2End phase estimated improvement -66ms [-76ms to -47ms] OR -7.54% [-8.73% to -5.34%]
clearManyItems2End phase estimated regression +3734ms [3710ms to 3751ms] OR +3440.17% [3418.96% to 3456.55%]
render1000Items3End phase estimated regression +33ms [16ms to 117ms] OR +38.11% [18.99% to 134.9%]
append1000Items1End phase no difference [-35ms to 17ms]
append1000Items2End phase estimated regression +120ms [91ms to 130ms] OR +71.82% [54.63% to 78.18%]
updateEvery10thItem1End phase estimated regression +14ms [7ms to 23ms] OR +16.81% [8.2% to 27.16%]
updateEvery10thItem2End phase no difference [0ms to 4ms]
selectFirstRow1End phase no difference [-1ms to 0ms]
selectSecondRow1End phase estimated improvement -20ms [-20ms to -19ms] OR -59.68% [-60.76% to -58.27%]
removeFirstRow1End phase estimated regression +4ms [3ms to 4ms] OR +7.14% [6.52% to 7.72%]
removeSecondRow1End phase no difference [0ms to 0ms]
swapRows1End phase no difference [0ms to 0ms]
swapRows2End phase no difference [0ms to 0ms]
clearItems4End phase estimated regression +1300ms [1285ms to 1313ms] OR +2185.17% [2158.84% to 2206.14%]
paint phase estimated regression +3ms [3ms to 3ms] OR +208.9% [198.34% to 218.05%]

[19:01:46] Generating Benchmark Reports [started]
[19:01:51] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

// "data" cell, it's value can be updated, and it's used to create derived cells
export class Cell<T extends unknown = unknown> {
_value!: T;
_value!: Signal.State<T>;
declare toHTML: () => string;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAAAS

@lifeart lifeart changed the title check-signals [experiment] check signals v1 May 3, 2024
@lifeart lifeart changed the title [experiment] check signals v1 🚨 [experiment] check signals v1 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants