Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set body to null if given empty buffer #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tompuric
Copy link

@tompuric tompuric commented Apr 6, 2023

Raised for: #127

Here's a PR that verifies the body is null. If the result data is an empty buffer, pass null as body instead.
Ideally I would like to verify the node16-18 behaviour but the tests here hard-code the fetch and Response implementation to utilise node-fetch which behaves differently to node18s native fetch that utilises undici.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants