New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-145225 #1413
LPS-145225 #1413
Conversation
ci:test:sf |
Hi, you don’t need to run the CI commands anymore, I’ll do it for you and let you know if any issue happens. |
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-145225 1 Successful Jobs:For more details click here. |
ci:test:relevant |
ci:test:forms |
❌ ci:test:forms - 7 out of 11 jobs passed in 1 hour 33 minutesClick here for more details.This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result: ci:reevaluate:1277401_1649 Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: c5a9a72d3a58a504233e4cc799652fc9f544ba5e ci:test:forms - 7 out of 11 jobs PASSED4 Failed Jobs:7 Successful Jobs:
For more details click here.This pull contains no unique failures.Failures in common with acceptance upstream results at c5a9a72:
|
✔️ ci:test:stable - 27 out of 31 jobs passed✔️ ci:test:relevant - 28 out of 32 jobs passed in 1 hour 50 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: c5a9a72d3a58a504233e4cc799652fc9f544ba5e ci:test:stable - 27 out of 31 jobs PASSED4 Failed Jobs:27 Successful Jobs:
ci:test:relevant - 27 out of 32 jobs PASSED5 Failed Jobs:
27 Successful Jobs:
For more details click here.This pull contains no unique failures.Failures in common with acceptance upstream results at c5a9a72:
|
bf43302
to
f63def4
Compare
f63def4
to
f626658
Compare
f626658
to
bb503d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @carolmariaabb. Good job on updating this old code! 👏🏻
I just have a few questions related to FE and I'm asking @miltonmc's assistance here.
.../main/resources/META-INF/resources/admin/js/components/export-form/ExportFormModalBody.es.js
Show resolved
Hide resolved
.../main/resources/META-INF/resources/admin/js/components/export-form/ExportFormModalBody.es.js
Show resolved
Hide resolved
.../main/resources/META-INF/resources/admin/js/components/export-form/openExportFormModal.es.js
Show resolved
Hide resolved
.../main/resources/META-INF/resources/admin/js/components/export-form/openExportFormModal.es.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent job!
I have just a few considerations to do:
Related Issue: https://issues.liferay.com/browse/LPS-145225