Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-145225 #1413

Closed
wants to merge 6 commits into from
Closed

Conversation

carolmariaabb
Copy link
Collaborator

@carolmariaabb carolmariaabb commented Feb 3, 2022

@liferay-forms
Copy link
Owner

ci:test:sf

@liferay-forms
Copy link
Owner

Hi, you don’t need to run the CI commands anymore, I’ll do it for you and let you know if any issue happens.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: c1fca5b78547be6db7a83edf2dcd2c1b14c46465

Sender Branch:

Branch Name: LPS-145225
Branch GIT ID: bf433020cf8ed9eef62a5608c196b399a1d7d16f

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-forms
Copy link
Owner

ci:test:relevant

@carolmariaabb
Copy link
Collaborator Author

ci:test:forms

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:forms - 7 out of 11 jobs passed in 1 hour 33 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1277401_1649

Base Branch:

Branch Name: master
Branch GIT ID: c1fca5b78547be6db7a83edf2dcd2c1b14c46465

Upstream Comparison:

Branch GIT ID: c5a9a72d3a58a504233e4cc799652fc9f544ba5e
Jenkins Build URL: Acceptance Upstream DXP (master) #2882

ci:test:forms - 7 out of 11 jobs PASSED
7 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at c5a9a72:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    781 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=0 #9646
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        The data provider was not able to connect to the web service. Unable to transmit request to localhost
          at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
          at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
          at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
          at java.nio.file.Files.walkFileTree(Files.java:2670)
          at java.nio.file.Files.walkFileTree(Files.java:2742)
          at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)
        
    2. AXIS_VARIABLE=1 #9646
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Duplicate entry '20100-com.liferay.portal.kernel.model.LayoutPrototype-4-com.life' for key 'IX_A9FF4B2C'
          at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
          at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
          at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
          at java.nio.file.Files.walkFileTree(Files.java:2670)
          at java.nio.file.Files.walkFileTree(Files.java:2742)
          at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)
        
  2. test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8/0
    Job Results:

    925 Tests Passed.
    19 Tests Failed.

    1. AXIS_VARIABLE=0 #482844
      1. com.liferay.dynamic.data.mapping.internal.upgrade.v3_10_2.DDMFormInstanceReportUpgradeProcessTest.testUpgradeDDMFormInstanceReportData
        java.lang.ExceptionInInitializerError
          at java.lang.Class.forName0(Native Method)
          at java.lang.Class.forName(Class.java:264)
          at javassist.runtime.Desc.getClassObject(Desc.java:43)
          at javassist.runtime.Desc.getClassType(Desc.java:152)
          at javassist.runtime.Desc.getType(Desc.java:122)
          at javassist.runtime.Desc.getType(Desc.java:78)
          at com.liferay.dynamic.data.mapping.internal.upgrade.v3_10_2.DDMFormInstanceReportUpgradeProcessTest.testUpgradeDDMFormInstanceReportData(DDMFormInstanceReportUpgradeProcessTest.java:43)
          at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
          at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          at java.lang.reflect.Method.invoke(Method.java:498)
          at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:68)
          at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runTestMethod(PowerMockJUnit44RunnerDelegateImpl.java:310)
          at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:89)
          at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:97)
          at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.executeTest(PowerMockJUnit44RunnerDelegateImpl.java:294)
          at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner...
      2. com.liferay.dynamic.data.mapping.internal.upgrade.v1_0_0.DynamicDataMappingUpgradeProcessTest.testCreateNewFieldNameWithConflictingNewFieldName
        java.lang.NoClassDefFoundError: Could not initialize class com.liferay.dynamic.data.mapping.internal.upgrade.v1_0_0.DynamicDataMappingUpgradeProcess
          at java.lang.Class.forName0(Native Method)
          at java.lang.Class.forName(Class.java:264)
          at javassist.runtime.Desc.getClassObject(Desc.java:43)
          at javassist.runtime.Desc.getClassType(Desc.java:152)
          at javassist.runtime.Desc.getType(Desc.java:122)
          at javassist.runtime.Desc.getType(Desc.java:78)
          at com.liferay.dynamic.data.mapping.internal.upgrade.v1_0_0.DynamicDataMappingUpgradeProcessTest.setUp(DynamicDataMappingUpgradeProcessTest.java:126)
          at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
          at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          at java.lang.reflect.Method.invoke(Method.java:498)
          at org.junit.internal.runners.MethodRoadie.runBefores(MethodRoadie.java:133)
          at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:96)
          at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.executeTest(PowerMockJUnit44RunnerDelegateImpl.java:294)
          at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTestInSuper(PowerMockJUnit47RunnerDelegateImpl.java:127)
          at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUn...
      3. com.liferay.dynamic.data.mapping.internal.upgrade.v1_0_0.DynamicDataMappingUpgradeProcessTest.testCreateNewFieldNameWithSupportedOldFieldName
        java.lang.NoClassDefFoundError: Could not initialize class com.liferay.dynamic.data.mapping.internal.upgrade.v1_0_0.DynamicDataMappingUpgradeProcess
          at java.lang.Class.forName0(Native Method)
          at java.lang.Class.forName(Class.java:264)
          at javassist.runtime.Desc.getClassObject(Desc.java:43)
          at javassist.runtime.Desc.getClassType(Desc.java:152)
          at javassist.runtime.Desc.getType(Desc.java:122)
          at javassist.runtime.Desc.getType(Desc.java:78)
          at com.liferay.dynamic.data.mapping.internal.upgrade.v1_0_0.DynamicDataMappingUpgradeProcessTest.setUp(DynamicDataMappingUpgradeProcessTest.java:126)
          at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
          at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          at java.lang.reflect.Method.invoke(Method.java:498)
          at org.junit.internal.runners.MethodRoadie.runBefores(MethodRoadie.java:133)
          at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:96)
          at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.executeTest(PowerMockJUnit44RunnerDelegateImpl.java:294)
          at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTestInSuper(PowerMockJUnit47RunnerDelegateImpl.java:127)
          at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUn...
      4. ...

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 27 out of 31 jobs passed

✔️ ci:test:relevant - 28 out of 32 jobs passed in 1 hour 50 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: c1fca5b78547be6db7a83edf2dcd2c1b14c46465

Upstream Comparison:

Branch GIT ID: c5a9a72d3a58a504233e4cc799652fc9f544ba5e
Jenkins Build URL: Acceptance Upstream DXP (master) #2882

ci:test:stable - 27 out of 31 jobs PASSED
27 Successful Jobs:
ci:test:relevant - 27 out of 32 jobs PASSED
27 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at c5a9a72:
  1. test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0
    Job Results:

    2 Tests Passed.
    3 Tests Failed.

    1. AXIS_VARIABLE=0 #26816
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog
        junit.framework.AssertionFailedError: 
        Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1643918478609.log:
        !SESSION 2022-02-03 20:01:32.912 -----------------------------------------------
        eclipse.buildId=unknown
        java.version=1.8.0_121
        java.vendor=Oracle Corporation
        BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
        

        !ENTRY com.liferay.portal.odata.impl 4 0 2022-02-03 20:01:32.912
        !MESSAGE FrameworkEvent ERROR
        !STACK 0
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.portal.odata.impl [154]
        Unresolved requirement: Import-Package: io.netty.buffer

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

        !ENTRY com.liferay.site.initializer.extender 4 0 2022-02-03 20:01...

      2. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError:
        FrameworkEvent ERROR
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.portal.odata.impl [154]
        Unresolved requirement: Import-Package: io.netty.buffer

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

        at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        at java.nio.file.Files.walkFileTree(Files.java:2670)
        at java.nio.file.Files.walkFileTree(Files.java:2742)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(Po...

  2. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    2926 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=3 #30937
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError:
        JSON storage adapter is deprecated, using default storage adapter
        at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        at java.nio.file.Files.walkFileTree(Files.java:2670)
        at java.nio.file.Files.walkFileTree(Files.java:2742)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)
  3. test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8/0
    Job Results:

    956 Tests Passed.
    19 Tests Failed.

    1. AXIS_VARIABLE=0 #28516
      1. com.liferay.dynamic.data.mapping.internal.upgrade.v3_10_2.DDMFormInstanceReportUpgradeProcessTest.testUpgradeDDMFormInstanceReportData
        java.lang.ExceptionInInitializerError
        at java.lang.Class.forName0(Native Method)
        at java.lang.Class.forName(Class.java:264)
        at javassist.runtime.Desc.getClassObject(Desc.java:43)
        at javassist.runtime.Desc.getClassType(Desc.java:152)
        at javassist.runtime.Desc.getType(Desc.java:122)
        at javassist.runtime.Desc.getType(Desc.java:78)
        at com.liferay.dynamic.data.mapping.internal.upgrade.v3_10_2.DDMFormInstanceReportUpgradeProcessTest.testUpgradeDDMFormInstanceReportData(DDMFormInstanceReportUpgradeProcessTest.java:43)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:68)
        at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runTestMethod(PowerMockJUnit44RunnerDelegateImpl.java:310)
        at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:89)
        at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:97)
        at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.executeTest(PowerMockJUnit44RunnerDelegateImpl.java:294)
        at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner...
      2. com.liferay.dynamic.data.mapping.internal.upgrade.v1_0_0.DynamicDataMappingUpgradeProcessTest.testCreateNewFieldNameWithConflictingNewFieldName
        java.lang.NoClassDefFoundError: Could not initialize class com.liferay.dynamic.data.mapping.internal.upgrade.v1_0_0.DynamicDataMappingUpgradeProcess
        at java.lang.Class.forName0(Native Method)
        at java.lang.Class.forName(Class.java:264)
        at javassist.runtime.Desc.getClassObject(Desc.java:43)
        at javassist.runtime.Desc.getClassType(Desc.java:152)
        at javassist.runtime.Desc.getType(Desc.java:122)
        at javassist.runtime.Desc.getType(Desc.java:78)
        at com.liferay.dynamic.data.mapping.internal.upgrade.v1_0_0.DynamicDataMappingUpgradeProcessTest.setUp(DynamicDataMappingUpgradeProcessTest.java:126)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.junit.internal.runners.MethodRoadie.runBefores(MethodRoadie.java:133)
        at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:96)
        at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.executeTest(PowerMockJUnit44RunnerDelegateImpl.java:294)
        at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTestInSuper(PowerMockJUnit47RunnerDelegateImpl.java:127)
        at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUn...
      3. com.liferay.dynamic.data.mapping.internal.upgrade.v1_0_0.DynamicDataMappingUpgradeProcessTest.testCreateNewFieldNameWithSupportedOldFieldName
        java.lang.NoClassDefFoundError: Could not initialize class com.liferay.dynamic.data.mapping.internal.upgrade.v1_0_0.DynamicDataMappingUpgradeProcess
        at java.lang.Class.forName0(Native Method)
        at java.lang.Class.forName(Class.java:264)
        at javassist.runtime.Desc.getClassObject(Desc.java:43)
        at javassist.runtime.Desc.getClassType(Desc.java:152)
        at javassist.runtime.Desc.getType(Desc.java:122)
        at javassist.runtime.Desc.getType(Desc.java:78)
        at com.liferay.dynamic.data.mapping.internal.upgrade.v1_0_0.DynamicDataMappingUpgradeProcessTest.setUp(DynamicDataMappingUpgradeProcessTest.java:126)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.junit.internal.runners.MethodRoadie.runBefores(MethodRoadie.java:133)
        at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:96)
        at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.executeTest(PowerMockJUnit44RunnerDelegateImpl.java:294)
        at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTestInSuper(PowerMockJUnit47RunnerDelegateImpl.java:127)
        at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUn...
      4. ...

Copy link

@rodrigopaulino rodrigopaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @carolmariaabb. Good job on updating this old code! 👏🏻

I just have a few questions related to FE and I'm asking @miltonmc's assistance here.

@rodrigopaulino rodrigopaulino added the Author Action Required Changes/Questions were requested by the reviewer label Feb 8, 2022
Copy link

@miltonmc miltonmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job!

I have just a few considerations to do:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants