chore(deps): bump engine.io from 4.1.1 to 4.1.2 #4577
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [engine.io](https://github.com/socketio/engine.io) from 4.1.1 to 4.1.2. - [Release notes](https://github.com/socketio/engine.io/releases) - [Changelog](https://github.com/socketio/engine.io/blob/4.1.2/CHANGELOG.md) - [Commits](socketio/engine.io@4.1.1...4.1.2) --- updated-dependencies: - dependency-name: engine.io dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
|
@matuzalemsteles just so you know, I fetched this branch and everything works fine for both packages/ and clayui.com so I'm merging |
|
Thanks @julien, ideally, instead of us merging the bot changes we would do this manually updating the package if necessary, following #4459 and eventually what the Dev Exp team is doing as well liferay/liferay-frontend-projects#112. |
|
@matuzalemsteles since we've never talked about this and nothing's documented I did what I thought was right. On top of that, what's the point of doing something #4459 (I'm really curious)? Are we just going to leave those "dependabot" pull requests open until "we think it's the right moment"? I've had lots of trouble making Clay work with node 14.x/16.x mainly because we don't update dependencies very often in Clay (or so it seems), and I think we should check them at least once per month, because given how unstable things can get with npm, I'd rather be safe than sorry. If you already have an idea of how to proceed that's great, but let's document it, you can't expect people to guess what they should do if it's not written down or if you don't tell them what you expect. |
|
@julien don't get me wrong, but I'm just following our policy that Security implications of dependencies that Greg had worked on the document, well, that wasn't created by me, I'm just following what we already do in the other repositories. In the issue #4459 I had the link to the document and the example for us to follow what the Dev Exp squad has been doing. |
Bumps engine.io from 4.1.1 to 4.1.2.
Release notes
Sourced from engine.io's releases.
Changelog
Sourced from engine.io's changelog.
Commits
c6315afchore(release): 4.1.2a70800dfix: properly handle invalid data sent by a malicious websocket clientDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.