Skip to content
This repository has been archived by the owner on Dec 5, 2020. It is now read-only.

chore(deps): bump minimist from 1.2.0 to 1.2.3 #463

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Apr 4, 2020

Bumps minimist from 1.2.0 to 1.2.3.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 4, 2020
@izaera
Copy link
Member

izaera commented Apr 6, 2020

Requesting changes to prevent accidental merges as per: https://github.com/liferay/liferay-frontend-guidelines/blob/master/general/security.md

@izaera izaera added the wontfix label Apr 6, 2020
Copy link
Member

@izaera izaera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to prevent accidental merges as per: https://github.com/liferay/liferay-frontend-guidelines/blob/master/general/security.md

@wincent
Copy link
Contributor

wincent commented Apr 6, 2020

Just noticed that you may be able to force this dependency to update via deleting the yarn.lock and regenerating it. At least, that worked in the simple case of liferay-frontend-guidelines. The dependency graph is more compilicated over here though (see output of yarn why minimist), so don't know if that would work — maybe some other dependencies would need updates too:

yarn why v1.17.3
[1/4] 🤔  Why do we have the module "minimist"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "minimist@1.2.0"
info Has been hoisted to "minimist"
info Reasons this module exists
   - "workspace-aggregator-e5149cd6-71df-4052-8991-3802214f4fba" depends on it
   - Hoisted from "_project_#liferay-theme-tasks#minimist"
   - Hoisted from "_project_#liferay-theme-tasks#gulp-util#minimist"
   - Hoisted from "_project_#generator-liferay-theme#yeoman-generator#minimist"
   - Hoisted from "_project_#generator-liferay-theme#gulp-coveralls#coveralls#minimist"
   - Hoisted from "_project_#liferay-theme-tasks#gulp-sass#node-sass#meow#minimist"
   - Hoisted from "_project_#liferay-theme-tasks#npm-keyword#registry-url#rc#minimist"
   - Hoisted from "_project_#jest#jest-cli#@jest#core#jest-haste-map#sane#minimist"
   - Hoisted from "_project_#jest#jest-cli#jest-config#@babel#core#json5#minimist"
   - Hoisted from "_project_#jest#jest-cli#@jest#core#jest-haste-map#sane#@cnakazawa#watch#minimist"
info Disk size without dependencies: "96KB"
info Disk size with unique dependencies: "96KB"
info Disk size with transitive dependencies: "96KB"
info Number of shared dependencies: 0
=> Found "mkdirp#minimist@0.0.8"
info This module exists because "_project_#eslint#mkdirp" depends on it.
info Disk size without dependencies: "72KB"
info Disk size with unique dependencies: "72KB"
info Disk size with transitive dependencies: "72KB"
info Number of shared dependencies: 0
✨  Done in 0.61s.

Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.3.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.3)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/minimist-1.2.3 branch from 0126d87 to a5654b3 Compare April 6, 2020 13:44
@izaera
Copy link
Member

izaera commented Apr 7, 2020

I would say mkdirp can be totally removed because we have fs-extra in place. I did the same with delete, which was removed some PRs ago.

Also notice that we can get rid of rimraf for the very same reason.

@izaera
Copy link
Member

izaera commented Apr 7, 2020

Oops. I didn't notice the dependency to mkdirp was through eslint 😬

@wincent
Copy link
Contributor

wincent commented Sep 7, 2020

Now that #505 is in, closing this, superseded by: #504

@wincent wincent closed this Sep 7, 2020
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Sep 7, 2020

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/minimist-1.2.3 branch September 7, 2020 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file wontfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants