Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add note with clarification how to pass -Dconfig properly; taken from… #763

Merged
merged 2 commits into from
Apr 1, 2022
Merged

add note with clarification how to pass -Dconfig properly; taken from… #763

merged 2 commits into from
Apr 1, 2022

Conversation

iamtodor
Copy link
Contributor

@lightbend-cla-validator
Copy link
Collaborator

Hi @iamtodor,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@iamtodor
Copy link
Contributor Author

@havocp should I also mention this way passing resource -Dconfig.resource=test.conf, how do you think?

@havocp
Copy link
Collaborator

havocp commented Mar 30, 2022

@havocp should I also mention this way passing resource -Dconfig.resource=test.conf, how do you think?

yes I guess the note applies to all of them?

@iamtodor
Copy link
Contributor Author

@havocp is there anything needed from my side? I see the tests are waiting for something.

@havocp
Copy link
Collaborator

havocp commented Mar 31, 2022

@havocp is there anything needed from my side? I see the tests are waiting for something.

It was sort of weirdly stuck yesterday for me when I tried to merge, but I was able to click run tests now. Some github glitch I guess.

@havocp havocp merged commit 4458ea9 into lightbend:main Apr 1, 2022
@iamtodor iamtodor deleted the add_dconfig_pass_clarification branch April 1, 2022 07:56
zeebe-bors-camunda bot added a commit to camunda/camunda that referenced this pull request Nov 3, 2023
@zeebe-bors-camunda @renovate
merge: #14989
eadfd55 
14989: deps(deps): update dependency com.typesafe:config to v1.4.3 (stable/8.0) r=github-actions[bot] a=renovate[bot]

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.typesafe:config](https://togithub.com/lightbend/config) | `1.4.2` -> `1.4.3` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.typesafe:config/1.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.typesafe:config/1.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.typesafe:config/1.4.2/1.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.typesafe:config/1.4.2/1.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>lightbend/config (com.typesafe:config)</summary>

### [`v1.4.3`](https://togithub.com/lightbend/config/releases/tag/v1.4.3): 1.4.3

[Compare Source](https://togithub.com/lightbend/config/compare/v1.4.2...v1.4.3)

#### What's Changed

-   Release 1.4.2 by [`@&#8203;raboof](https://togithub.com/raboof)` in [lightbend/config#759
-   add note with clarification how to pass -Dconfig properly; taken from… by [`@&#8203;iamtodor](https://togithub.com/iamtodor)` in [lightbend/config#763
-   readme: change playground url by [`@&#8203;av-elier](https://togithub.com/av-elier)` in [lightbend/config#775
-   Update maintenance note by [`@&#8203;ennru](https://togithub.com/ennru)` in [lightbend/config#788
-   Make the issue template work by [`@&#8203;ennru](https://togithub.com/ennru)` in [lightbend/config#791
-   fix: Optionally hide rendered environment variables by [`@&#8203;patriknw](https://togithub.com/patriknw)` in [lightbend/config#798
-   chore: update NEWS and release 1.4.3 by [`@&#8203;patriknw](https://togithub.com/patriknw)` in [lightbend/config#799

#### New Contributors

-   [`@&#8203;iamtodor](https://togithub.com/iamtodor)` made their first contribution in [lightbend/config#763
-   [`@&#8203;patriknw](https://togithub.com/patriknw)` made their first contribution in [lightbend/config#798

**Full Changelog**: lightbend/config@v1.4.2...v1.4.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/camunda/zeebe).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6InN0YWJsZS84LjAifQ==-->


Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havocp havocp havocp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iamtodor @lightbend-cla-validator @havocp