Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add new shopping cart quickstarts #381

Merged
merged 3 commits into from
Jul 1, 2022

Conversation

pvlugter
Copy link
Member

@pvlugter pvlugter commented Jul 1, 2022

Refs https://github.com/lightbend/kalix/issues/6959

Add new shopping cart quickstart samples and docs for both JavaScript and TypeScript. This is a blend of the existing sample and quickstart guide in the main docs, and the quickstarts for JVM SDKs. Again, added as new samples with the old samples left as is for now.

The TypeScript version is more defensive than needed, as the types it's currently working with are | null | undefined optional, while the actual deserialised types have defaults set. This is issue #326, and something to come back to here.

@github-actions github-actions bot added Documentation Improvements or additions to documentation javascript-sdk kalix-runtime Runtime and SDKs sub-team typescript-sdk labels Jul 1, 2022
Copy link
Contributor

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johanandren johanandren merged commit 9cc6143 into lightbend:main Jul 1, 2022
@pvlugter pvlugter deleted the shopping-cart-quickstarts branch July 3, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation javascript-sdk kalix-runtime Runtime and SDKs sub-team typescript-sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants