Downgrade hashbrown to meet MSRV
#1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2022-09-downgrade-hashbrown
branch
from
ca6fe90
to
1efd210
Compare
Codecov ReportBase: 90.73% // Head: 90.72% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1733 +/- ##
==========================================
- Coverage 90.73% 90.72% -0.01%
==========================================
Files 86 86
Lines 46688 46688
Branches 46688 46688
==========================================
- Hits 42361 42358 -3
- Misses 4327 4330 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
`hashbrown` depends on `ahash` which depends on `once_cell`. Sadly, in matklad/once_cell#201 the `once_cell` maintainer decided they didn't want to do the work of having an MSRV policy for `once_cell`, making `ahash`, and thus `hashbrown` require the latest compiler. I've reached out to `ahash` to suggest they drop the dependency (as they could trivially work around not having it), but until then we simply downgrade `hashbrown`. `rust-bitcoin` also requires an older `hashbrown` so we're actually reducing our total `no-std` code here anyway.
TheBlueMatt
force-pushed
the
2022-09-downgrade-hashbrown
branch
from
1efd210
to
2e7d924
Compare
valentinewallace
approved these changes
Sep 22, 2022
tnull
approved these changes
Sep 22, 2022
dunxen
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hashbrowndepends onahashwhich depends ononce_cell. Sadly, in matklad/once_cell#201 theonce_cellmaintainer decided they didn't want to do the work of having an MSRV policy foronce_cell, makingahash, and thushashbrownrequire the latest compiler. I've reached out toahashto suggest they drop the dependency (as they could trivially work around not having it), but until then we simply downgradehashbrown.rust-bitcoinalso requires an olderhashbrownso we're actually reducing our totalno-stdcode here anyway.