-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
funding: add absent error logs for failed inbound funding requests #8663
funding: add absent error logs for failed inbound funding requests #8663
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
28fce49
to
057b95a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please squash the two commits together? Then this looks good to me, thanks.
For failed inbound funding requests, add missing error logs and make sparse error logs more descriptive.
057b95a
to
593a564
Compare
@yyforyongyu: review reminder |
Change Description
Add missing error logs when the ChannelAcceptor does not enable zero-conf in the ChannelAcceptResponse to an incoming funding request with the zero-conf feature enabled.
Steps to Test
To test this connect a channel acceptor to the lnd node that accepts incoming channels but sets zero_conf to false.
For example a Python script that connects through gRPC:
Then use another node to try opening a zero-conf channel to the lnd node with this patch. The expected behavior is an error message in the lnd logs stating
channel acceptor blocked zero-conf channel negotiation
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]
in the commit message for small changes.馃摑 Please see our Contribution Guidelines for further guidance.