Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lncli: new command wallet estimatefeerate #8730

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lncli: new command wallet estimatefeerate #8730

wants to merge 1 commit into from

Conversation

feelancer21
Copy link
Contributor

@feelancer21 feelancer21 commented May 5, 2024 •
edited

lncli wallet estimatefee returns the fee estimation of the onchain backend to achieve a given confirmation target.

fixes #8726

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented May 5, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@feelancer21 feelancer21 marked this pull request as draft May 6, 2024 00:52
@feelancer21 feelancer21 mentioned this pull request May 6, 2024
Open
@feelancer21 feelancer21 marked this pull request as ready for review May 7, 2024 22:30
guggero
guggero reviewed May 8, 2024
View reviewed changes
cmd/lncli/walletrpc_active.go Outdated
@@ -124,6 +126,45 @@ func getWalletClient(ctx *cli.Context) (walletrpc.WalletKitClient, func()) {
return walletrpc.NewWalletKitClient(conn), cleanUp
}

var estimateOnchainFeeCommand = cli.Command{
Name: "estimatefee",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this will return a fee rate (not an absolute fee), I think we should rename the command to estimatefeerate (which will also help to differentiate it from the existing top-level estimatefee command.

ellemouton
ellemouton reviewed May 8, 2024
View reviewed changes
Copy link
Collaborator

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK! Looking good - a couple of nits & also think the estimatefeerate name would still work better

cmd/lncli/walletrpc_active.go Outdated Show resolved Hide resolved
cmd/lncli/walletrpc_active.go Outdated Show resolved Hide resolved
cmd/lncli/walletrpc_active.go Outdated Show resolved Hide resolved
cmd/lncli/walletrpc_active.go Outdated Show resolved Hide resolved
cmd/lncli/walletrpc_active.go Outdated Show resolved Hide resolved
cmd/lncli/walletrpc_active.go Show resolved Hide resolved
cmd/lncli/walletrpc_active.go Outdated Show resolved Hide resolved
@feelancer21
Copy link
Contributor Author

@ellemouton @guggero: Thanks for the fast review. I have added all your comments to the code.

@ellemouton
Copy link
Collaborator

ellemouton commented May 8, 2024 •
edited

@feelancer21 - I dont think all the comments were addressed (referring to the s/feerate/fee rate comments)

@guggero guggero changed the title lncli: new command wallet estimatefee lncli: new command wallet estimatefeerate May 8, 2024
@feelancer21
lncli: new command wallet estimatefeerate
c3792dc 
`lncli wallet estimatefeerate` returns the fee rate estimate for on-chain
transactions in sat/kw to achieve a given confirmation target.
@feelancer21
Copy link
Contributor Author

Sorry, my brain read "s/fee/feerate/" and skipped it. Is added now.

ellemouton
ellemouton reviewed May 8, 2024
View reviewed changes
Copy link
Collaborator

@ellemouton ellemouton left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good - last comment is about instead moving this out of the wallet commands and to instead add it to the On-chain command sent since this isnt wallet related

EDIT: let me check with @guggero first to see if he agrees though

EDIT: never mind - i see it depends on wallet rpc

ellemouton
ellemouton approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@feelancer21
Copy link
Contributor Author

feelancer21 commented May 8, 2024 •
edited

Great. Yes, the dependency to walletrpc was the reason to make it a subcommand for lncli wallet.

@saubyk saubyk added wallet The wallet (lnwallet) which LND uses fees Related to the fees paid for transactions (both LN and funding/commitment transactions) rpc Related to the RPC interface labels May 8, 2024
@lightninglabs-deploy
Copy link

@feelancer21, remember to re-request review from reviewers when ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guggero guggero guggero left review comments

@ellemouton ellemouton ellemouton approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@feelancer21 feelancer21

Labels
fees Related to the fees paid for transactions (both LN and funding/commitment transactions) rpc Related to the RPC interface wallet The wallet (lnwallet) which LND uses
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature]: lncli command for walletrpc.EstimateFee
5 participants
@feelancer21 @ellemouton @lightninglabs-deploy @guggero @saubyk