Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change defaults: stateless temporality preference, lightstep metrics SDK #258

Merged
merged 7 commits into from Aug 27, 2022

Conversation

jmacd
Copy link
Member

@jmacd jmacd commented Aug 26, 2022

Description: Changes the defaults for Lightstep's metrics SDK to use stateless temporality.

Link to tracking Issue:
Fixes #256

Testing: Also fixed a test, broken at HEAD, because I skipped a check (intentionally, but misunderstood why), see #254.

Documentation: Changelog, README.

Copy link
Contributor

@kayousterhout kayousterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also fix the config options table in the readme to have the correct (delta) default for the temporality? It currently says the default is false

@codecov-commenter
Copy link

Codecov Report

Merging #258 (2e436d1) into main (47a4f6e) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
+ Coverage   94.21%   94.32%   +0.10%     
==========================================
  Files          66       66              
  Lines        3494     3505      +11     
==========================================
+ Hits         3292     3306      +14     
+ Misses        155      152       -3     
  Partials       47       47              
Impacted Files Coverage Δ
launcher/config.go 88.94% <ø> (ø)
...dk/metric/aggregator/histogram/structure/config.go 100.00% <ø> (ø)
.../sdk/metric/aggregator/histogram/structure/test.go 100.00% <ø> (ø)
pipelines/metrics.go 67.93% <ø> (+2.29%) ⬆️
...tric/aggregator/histogram/structure/exponential.go 96.67% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jmacd jmacd merged commit 15409ad into main Aug 27, 2022
@jmacd jmacd deleted the jmacd/new_default branch September 13, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Lightstep metrics SDK exclusive until the new community SDK is available
3 participants