Issue an error message when trying to run on NFS #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
May 7, 2024
| return err | ||
| } | ||
| if nfs { | ||
| return errors.New("must not run on NFS dir") |
There was a problem hiding this comment.
Probably this should be just a warning?
It still may work on NFS with a future potential version of QEMU, vz, or something else?
There was a problem hiding this comment.
Possibly, but I'm not sure if it is something that can be supported?
We can download/copy the "basedisk" from a remote location, such as ~/.cache, but keeping the "diffdisk" on a network file share could be a potential source of bugs and performance issues. Even if the bug here, regarding file locking with qemu-img, can be found and fixed? Something like iSCSI could work, but skeptical about NFS.
|
Apparently unix.NFS_SUPER_MAGIC is only defined on Linux (not Unix). |
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display an error message, when trying to put $LIMA_HOME on NFS network filesystem (instead of local filesystem)
Closes #2325