Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example that processes streaming replies in a blocking … #2068

Merged
merged 2 commits into from
Sep 16, 2019

Conversation

anuraaga
Copy link
Collaborator

To help with #2065

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #2068 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2068      +/-   ##
============================================
+ Coverage     73.79%   73.79%   +<.01%     
- Complexity     9391     9393       +2     
============================================
  Files           817      817              
  Lines         36121    36121              
  Branches       4452     4452              
============================================
+ Hits          26654    26655       +1     
+ Misses         7168     7166       -2     
- Partials       2299     2300       +1
Impacted Files Coverage Δ Complexity Δ
.../linecorp/armeria/internal/IdleTimeoutHandler.java 80% <0%> (-20%) 4% <0%> (-1%)
...inecorp/armeria/server/grpc/ArmeriaServerCall.java 87% <0%> (-1.19%) 82% <0%> (ø)
...inecorp/armeria/server/HttpResponseSubscriber.java 83.88% <0%> (-0.48%) 64% <0%> (-1%)
...meria/common/stream/RegularFixedStreamMessage.java 87.75% <0%> (ø) 14% <0%> (ø) ⬇️
...com/linecorp/armeria/server/HttpServerHandler.java 81.08% <0%> (+0.33%) 81% <0%> (+1%) ⬆️
...rp/armeria/common/stream/DefaultStreamMessage.java 90.71% <0%> (+1.42%) 54% <0%> (+1%) ⬆️
...meria/internal/AbstractHttp2ConnectionHandler.java 96.66% <0%> (+3.33%) 14% <0%> (+1%) ⬆️
.../linecorp/armeria/internal/Http2ObjectEncoder.java 80% <0%> (+8.57%) 13% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 379d0e8...d826dfc. Read the comment docs.

@trustin trustin added this to the 0.92.0 milestone Sep 13, 2019
Copy link
Member

@trustin trustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @anuraaga ❤️

Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trustin trustin changed the title Add an example that processes streaming replies in a blocking way. Add an example that processes streaming replies in a blocking … Sep 16, 2019
@trustin trustin merged commit 3f0e2e9 into line:master Sep 16, 2019
eugene70 pushed a commit to eugene70/armeria that referenced this pull request Oct 16, 2019
fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants